Bump bazelversion to 8 #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing in favor of #107 |
hofbi
commented
Feb 6, 2025
.bazelrc
Outdated
Comment on lines
38
to
40
| # Default changed in bazel 8 | ||
| # See: https://github.com/bazelbuild/bazel/commit/489d08bf472f4568b3f7f478a8747a30cb956111 | ||
| build --zip_undeclared_test_outputs=true |
There was a problem hiding this comment.
This is the easy solution to make it work with bazel 8. Getting rid of this flag might require some changes in the rostest impl of this repo.
There was a problem hiding this comment.
Interesting, thanks for digging into this. Do you know what changes are needed?
There was a problem hiding this comment.
No, I didn't dig deeper into the problem. But with the new default from Bazel 8, you would have a directory structure instead of a .zip file in some test output folder. Any immediate idea where this could be problematic?
mvukov
reviewed
Feb 9, 2025
.bazelrc
Outdated
| @@ -35,6 +35,10 @@ build --nolegacy_external_runfiles | |||
| # Don't bother building targets which aren't dependencies of the tests. | |||
| test --build_tests_only | |||
|
|
|||
| # Default changed in bazel 8 | |||
There was a problem hiding this comment.
Please rephrase that this is mandatory at the moment.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see what needs to be done to make it work with Bazel 8