Drop dependency on Boost #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #238 (comment), Boost is only needed for Foxglove. It turns out it isn't actually needed there either (anymore?).
In Foxglove itself, there is only a ROS 1 Smoketest that needs boost::filesystem. So nothing we need to care about. https://github.com/search?q=repo%3Afoxglove%2Fros-foxglove-bridge%20boost&type=code
In ROS 2's resource_retriever, It seems like there was some Boost going on in the past, but on the Humble branch there definitely isn't any: https://github.com/ros/resource_retriever/blob/humble/resource_retriever/include/resource_retriever/retriever.hpp
Unless I missed something it seems to be we can just drop the dependency on Boost altogether in rules_ros2.