Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make finding aggregator_node runfile bzlmod compatible #257

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Make finding aggregator_node runfile bzlmod compatible #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14943aa
Make finding aggregator_node runfile bzlmod compatible
lalten Jan 28, 2024
ee7f273
Merge branch 'main' into aggregator_node-runfiles
mvukov Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ros2/test/diagnostics/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,6 @@ ros2_test(
deps = [
"@ros2_common_interfaces//:py_diagnostic_msgs",
"@ros2_rclpy//:rclpy",
"@rules_python//python/runfiles",
],
)
6 changes: 5 additions & 1 deletion ros2/test/diagnostics/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,12 @@
import launch_testing.actions
import launch_testing.asserts
import launch_testing.markers
import python.runfiles
import rclpy

AGGREGATOR_NODE_PATH = python.runfiles.Runfiles.Create().Rlocation(
'ros2_diagnostics/aggregator_node')
mvukov marked this conversation as resolved.
Show resolved Hide resolved


@launch_testing.markers.keep_alive
def generate_test_description():
Expand All @@ -32,7 +36,7 @@ def generate_test_description():
)

aggregator_node = launch_ros.actions.Node(
executable='../ros2_diagnostics/aggregator_node',
executable=AGGREGATOR_NODE_PATH,
name='diagnostic_aggregator',
parameters=['ros2/test/diagnostics/aggregator_config.yaml'],
)
Expand Down
Loading