Disable warnings for cyclonedds dependency #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvukov
reviewed
Nov 30, 2024
mering
force-pushed
the
disable-cyclonedds-warnings
branch
from
5dd5e01 to
b17d4c5
Compare
mvukov
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unforatuntely, there is no generic way to disable such warnings (bazel-contrib/rules_foreign_cc#1332) but instead it needs to be done for every
rules_foreign_cctarget explicitly.I also created eclipse-cyclonedds/cyclonedds#2146 upstream to fix the warning in the first place such that this workaround can be removed in the future.