Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up use of argument splats #101

Merged
merged 10 commits into from
Dec 28, 2023
Merged

Clean up use of argument splats #101

merged 10 commits into from
Dec 28, 2023

Conversation

mvz
Copy link
Owner

@mvz mvz commented Dec 28, 2023

Where possible, rely on Ruby to handle arguments, rather than decomposing argument lists by hand.

  • Make arguments for Common.location_for_eval explicit
  • Make arguments for replacement Kernel#eval explicit
  • Make arguments for replacement Binding#eval explicit
  • Explain need for args splats in #instance_eval and #module_eval replacements
  • Make arguments for LiveAST::Cache.new explicit
  • Make arguments to LiveAST::Evaler.eval explicit
  • Inline argument checking in LiveAST::Evaler.eval
  • Explicitly forward arguments in LiveAST::Linker.new_cache_synced
  • Explicitly forward arguments in Kernel#caller replacement
  • Explicitly forward arguments in Kernel#raise replacement

@mvz mvz merged commit 0e1bc07 into master Dec 28, 2023
4 checks passed
@mvz mvz deleted the clean-up-splats branch December 28, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant