Skip to content

Commit

Permalink
Makefile: don't zip
Browse files Browse the repository at this point in the history 
zip is not supported in some build environments, and really not
necessary.
  • Loading branch information
@mwilck
mwilck committed Mar 1, 2019
1 parent 4cf894b commit c2d8ef8
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion Makefile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ dist: compile
# We need to do this like this as 'zip' always uses the cwd as archive root.
# And for the extension to work extension.js etc. need to be at the root.
mkdir -p $(DISTDIR);
cd $(BUILDDIR); zip -rq ../dist/[email protected] ./*
cd $(BUILDDIR); tar -czf ../dist/[email protected] *
@ls -l dist

Expand Down

5 comments on commit c2d8ef8

@DirkHoffmann
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upload interface for gnome-shell extensions requests a ZIP file. Do you have different information/experience?

If some environments do not allow to generate it — I agree it is not mandatory for the actual development process, as is the documentation stuff with sphinx by the way. — wouldn't it be more appropriate (and compatible) to check, if ZIP is available and if not, skip it?

@mwilck
Copy link
Owner Author

@mwilck mwilck commented on c2d8ef8 Feb 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upload interface for gnome-shell extensions requests a ZIP file.

I wasn't aware of that and found one archive format sufficient. I haven't tried to upload my stuff to extensions.gnome.org, as there are already 3 hamster versions there (none if which is probably functional with current GNOME shell versions, I haven't tried).

I have no problem with reverting this commit.

@DirkHoffmann
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. OK for revert. 👍

There are four hamster extensions uploaded actually, none of them works. But that is another story.

@mwilck
Copy link
Owner Author

@mwilck mwilck commented on c2d8ef8 Feb 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Four even 🤦‍♂️ That was my point in the other thread, we need to clean this up somehow.

@mwilck
Copy link
Owner Author

@mwilck mwilck commented on c2d8ef8 Feb 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed the revert to my master branch.

Please sign in to comment.