Modify brili to properly execute phi instructions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerhou
force-pushed
the
fix-phi-swap
branch
from
6ded4c1 to
7a3bd95
Compare
This fixes issue 330: sampsyo#330 The approach (copy the environment at the end of the last basic block) was inspired/copied from the comment on the Bril issue: sampsyo#330 (comment)
tylerhou
force-pushed
the
fix-phi-swap
branch
from
7a3bd95 to
7fdc32a
Compare
|
Nice, I like this fix. Pretty minimally invasive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue 330: sampsyo#330
The approach (copy the environment at the end of the last basic block) was inspired/copied from the comment on the Bril issue: sampsyo#330 (comment)