Redefine json structure. #29
Merged
+17
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use name of Entites as a key in dict and positions as values. It allows to use full power of dict structure. What's more it simplify the code by removing unnecessary for loop and if-else closure
|
This PR corresponds to #24 issue |
|
Seems like a good idea, looking forward to your next PR's. Thanks for contributing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use name of
Entitesas a keys in dict andpositionsas values.It allows to use full power of dict structure. What's more,
it simplify the code by removing unnecessary for loop and
if-else closure.
If you like these changes and approve them, I'll make the same for the rest of stuff in json file. It'll simplify the code a lot.
I also included here small minor updates, like star expressions and removing redundant lines.