'Cancel' for PromiseKit: fix for #1026, plus cleanup #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dougzilla32
commented
Mar 23, 2019
dougzilla32
commented
- Fix "Typechecking timeout compiling tests in v7 Typechecking timeout compiling tests in v7 #1026" by specifying the closure return type in DispatcherTests
- Remove unnecessary "#if swift" checks in the cancellable code and tests
* Fix "Typechecking timeout compiling tests in v7 #1026" by specifying the closure return type in DispatcherTests * Remove unnecessary "#if swift" checks in the cancellable code and tests
This was referenced Mar 23, 2019
|
Hmmmm, dunno why the code coverage check is failing... |
|
CodeCOV is a little flakey at times |
mxcl
added a commit
that referenced
this pull request
Mar 26, 2019
'Cancel' for PromiseKit: fix for #1026, plus cleanup
mxcl
added a commit
that referenced
this pull request
Apr 8, 2019
'Cancel' for PromiseKit: fix for #1026, plus cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.