Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purpose/labelling of "Clear sample list" button and dialog #1420

Open
axelboc opened this issue Sep 26, 2024 · 1 comment
Open

Purpose/labelling of "Clear sample list" button and dialog #1420

axelboc opened this issue Sep 26, 2024 · 1 comment

Comments

@axelboc
Copy link
Collaborator

axelboc commented Sep 26, 2024

See #1419: I wonder whether the naming of the "Clear sample list" button is right... The main action is in fact the clearing of the queue... This is the action that has an impact of the beamline's state, whereas clearing the samples list relates only to the UI.

  • Should the button say "Clear queue" instead?
  • Should the button not clear the queue and just clear the sample list?
  • Should there be two separate buttons (and maybe the clear queue button should go on the Data collection screen)?
@axelboc
Copy link
Collaborator Author

axelboc commented Sep 26, 2024

As pointed out by @meguiraun, the action does not unmount the sample, yet the mounted sample disappears from the UI. This feels like a major issue to me. EDIT: more questions 😄

  • Should the UI at least indicate that a sample is mounted somehow, even if it doesn't have any info on the mounted sample?
  • Should the "Clear sample list" dialog mention something about the mounted sample disappearing from the UI and that user should resync with sample changer or LIMS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant