Extract and refactor clear queue dialog #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meguiraun
reviewed
Sep 26, 2024
axelboc
commented
Sep 26, 2024
There was a problem hiding this comment.
I kept this generic ConfirmActionDialog component even though it's only used by the ClearQueueDialog. I think it's a good abstraction so it seemed worth keeping.
| @@ -54,6 +55,7 @@ function Main() { | |||
| )} | |||
|
|
|||
| <SelectProposalContainer /> | |||
| <ClearQueueDialog /> | |||
There was a problem hiding this comment.
Sure, this dialog only makes sense in the context of the Samples page, but it doesn't really matter since its state is managed globally. I prefer to have all the dialogs in one place. It might uncover opportunities to simplify the global state and combine a few dialogs together into more general abstractions.
There was a problem hiding this comment.
Yes, it would be nice to only have, if possible, one main dialog component
axelboc
force-pushed
the
ab-clear-queue-dialog
branch
from
9e6677d
to
aa95233
Compare
|
Thanks ! |
marcus-oscarsson
force-pushed
the
ab-clear-queue-dialog
branch
from
aa95233
to
a112275
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still continuing to convert class components. Here I'm mainly focusing on the dialog that appears when clicking on the "Clear sample list" button to confirm the action. I'm creating a dedicated component for this dialog so it is self-contained and can be extracted from the
SampleListViewContainercomponent.I'm also tweaking the UX of the dialog slightly:
warningtheme variantand unmounts the current sample, if any.The last point makes me wonder whether the naming of the "Clear sample list" button is right... The main action is in fact the clearing of the queue... I'll open an issue to discuss this.