-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react-contexify] update to 6.0.0 #1428
Conversation
There are a bunch of changes in v6, including breaking changes (CSS import path, CSS classes, etc.), might be worth doubling checking those. There may also be opportunities to improve/simplify the code with some of the new features, maybe? 🤷 https://github.com/fkhadra/react-contexify/releases/tag/v6.0.0 |
53bdde2
to
d598432
Compare
d598432
to
37e6973
Compare
Yes. We can even remove the use of this library since we had some issues with the positioning in the pass for menu with very big Height. We have a Generic ContexMenu Component already we can make the necessary modifications to make it work everywhere. |
@jbflo, yes I remember that we already discussed. Sounds like a good idea then |
37e6973
to
b3e2e21
Compare
I had a look at the Release notes [I should had check before sorry] You can Merge this as it is. |
It's worth merging I think, in case the refactor/migration to the other solution takes longer than expected. |
b3e2e21
to
1352780
Compare
Thanks guys ! |
1352780
to
a826cd1
Compare
a826cd1
to
855d8a4
Compare
This fix Issue