Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-contexify] update to 6.0.0 #1428

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

jbflo
Copy link
Member

@jbflo jbflo commented Sep 30, 2024

This fix Issue

@axelboc
Copy link
Collaborator

axelboc commented Oct 1, 2024

There are a bunch of changes in v6, including breaking changes (CSS import path, CSS classes, etc.), might be worth doubling checking those. There may also be opportunities to improve/simplify the code with some of the new features, maybe? 🤷 https://github.com/fkhadra/react-contexify/releases/tag/v6.0.0

@marcus-oscarsson
Copy link
Member

@axelboc, yes that would probably be worth doing. What do you think @jbflo ? Ill merge this for now though as it seems to fix the issue, and then we can follow up with some improvements.

@marcus-oscarsson
Copy link
Member

@jbflo, @axelboc, is it perhaps worth double checking the impact of the backward incompatible changes before merging ?

@jbflo
Copy link
Member Author

jbflo commented Oct 1, 2024

Yes. We can even remove the use of this library since we had some issues with the positioning in the pass for menu with very big Height.

We have a Generic ContexMenu Component already we can make the necessary modifications to make it work everywhere.

@marcus-oscarsson
Copy link
Member

@jbflo, yes I remember that we already discussed. Sounds like a good idea then

@jbflo
Copy link
Member Author

jbflo commented Oct 1, 2024

@jbflo, yes I remember that we already discussed. Sounds like a good idea then

I had a look at the Release notes [I should had check before sorry]
I made the change for the css Breaking changes. but it's weird that it was still working with the old css path.

You can Merge this as it is.
Or
we can close this one and go on [all in one] improve/simplify the code on another PR.
both fine by me.

@axelboc
Copy link
Collaborator

axelboc commented Oct 1, 2024

It's worth merging I think, in case the refactor/migration to the other solution takes longer than expected.

@marcus-oscarsson
Copy link
Member

Thanks guys !

@marcus-oscarsson marcus-oscarsson merged commit 22e48c5 into develop Oct 3, 2024
16 checks passed
@marcus-oscarsson marcus-oscarsson deleted the jb-devlop-context-menu branch October 3, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seems like [react-contexify] Context Menu stopped working
3 participants