Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python3 module, various GCC warnings and Makefile issues #1

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sdebionne
Copy link

This will probably requires further improvements to make it a Conda package.

  • Improve build system to make it Conda compatible (e.g. use $CC and other env variables) rather than hardcoded values
  • Write a conda recipe

@sdebionne sdebionne force-pushed the fix-python-3-and-makefile branch 2 times, most recently from c60504d to bb5254a Compare July 16, 2020 09:48
@sdebionne
Copy link
Author

For the records, the test that ships with the codebase fails with:

RuntimeError: could not integrate function

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/debionne/miniconda3/envs/lima/lib/python3.7/pdb.py", line 1697, in main
    pdb._runscript(mainpyfile)
  File "/home/debionne/miniconda3/envs/lima/lib/python3.7/pdb.py", line 1566, in _runscript
    self.run(statement)
  File "/home/debionne/miniconda3/envs/lima/lib/python3.7/bdb.py", line 585, in run
    exec(cmd, globals, locals)
  File "<string>", line 1, in <module>
  File "/mnt/c/Users/debionne/Dev/pychooch/test_pychooch.py", line 1, in <module>
    import PyChooch
  File "/mnt/c/Users/debionne/Dev/pychooch/test_pychooch.py", line 11, in main
    result = PyChooch.calc(data, "Se", "K")
SystemError: <built-in function calc> returned a result with an error set

The GSL function that throws is gsl_integration_qag.

@beenje
Copy link
Contributor

beenje commented Aug 20, 2024

I missed that PR but basically did the same for Python 3 support in #2 + some update to latest chooch version.

The issue you mentioned was due to bug fixed in d08d636 upstream.

We created a local conda package at MAX IV. If there is interest, we could try to submit it to conda-forge.

@beenje
Copy link
Contributor

beenje commented Aug 26, 2024

chooch and pychooch are now on conda-forge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants