support bedrock and bedrock runtime resources #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxiamxia
force-pushed
the
v1_32_1_dev_bedrock
branch
from
f3139a0 to
2464029
Compare
mxiamxia
force-pushed
the
v1_32_1_dev_bedrock
branch
from
2464029 to
d9030c2
Compare
mxiamxia
commented
Jul 2, 2024
...s-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/Serializer.java
Outdated
Show resolved
Hide resolved
mxiamxia
commented
Jul 2, 2024
mxiamxia
commented
Jul 2, 2024
...ry/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AwsExperimentalAttributes.java
Outdated
Show resolved
Hide resolved
mxiamxia
commented
Jul 2, 2024
...s-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/Serializer.java
Outdated
Show resolved
Hide resolved
bjrara
reviewed
Jul 4, 2024
...-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/FieldMapper.java
Outdated
Show resolved
Hide resolved
...ry/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AwsExperimentalAttributes.java
Outdated
Show resolved
Hide resolved
...s-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/Serializer.java
Outdated
Show resolved
Hide resolved
...s-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/Serializer.java
Outdated
Show resolved
Hide resolved
...s-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/Serializer.java
Outdated
Show resolved
Hide resolved
...s-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/Serializer.java
Outdated
Show resolved
Hide resolved
...s-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/Serializer.java
Outdated
Show resolved
Hide resolved
...s-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/Serializer.java
Outdated
Show resolved
Hide resolved
...s-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/Serializer.java
Outdated
Show resolved
Hide resolved
bjrara
reviewed
Jul 5, 2024
.../src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/TracingExecutionInterceptor.java
Outdated
Show resolved
Hide resolved
...ry/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AwsExperimentalAttributes.java
Show resolved
Hide resolved
...ry/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AwsExperimentalAttributes.java
Show resolved
Hide resolved
...-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/FieldMapper.java
Outdated
Show resolved
Hide resolved
bjrara
reviewed
Jul 5, 2024
.../src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/TracingExecutionInterceptor.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add AWS Bedrock and BedrockRuntime support for AWS Java SDK V2 with the following change:
A. Bedrock:
Extract
guardrailIdfrom API response, and add into"aws.bedrock.guardrail.id"span attribute.B. Bedrock Agent:
Extract
agentIdfrom both API request and response, and add into"aws.bedrock.agent.id"span attribute.Extract
knowledgeBaseIdfrom API request, and add into"aws.bedrock.knowledgebase.id"span attribute.Extract
dataSourceIdfrom both API request and response,, and add into"aws.bedrock.datasource.id"span attribute.The instrumentation is on API operation level, we make sure only one attribute is extracted per API call, there will be no overlap/conflict to identify the resouce.
C. Bedrock Agent Runtime:
Extract
agentIdfrom API request, and add into"aws.bedrock.agent.id"span attribute.Extract
knowledgeBaseIdfrom API request, and add into"aws.bedrock.knowledgebase.id"span attribute.D. Bedrock Runtime:
Extract the following attributes and add into span according to Gen AI semantic-conventions:
Testing: E2E test performed to confirm trace span are generated correctly:
