add quick save option via screensaver shortcut #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new default behavior that is enabled by uncommenting https://github.com/warrenwinter/O_C/blob/5ff81313f65ddda4f3e749f53976a76de1d004b9/software/o_c_REV/OC_options.h#L34 : the module will then save all settings (identical to how it is done from the app selection menu) every time the user manually switches to the screensaver (using a given app's screensaver shortcut, e.g., long-press of the up-button in Quantermain).
I considered other single-action shortcuts for this but couldn't think of another that didn't present a functional conflict when changing app settings. Since this involves erring on the side of over-saving, it's offered as an option, which might appeal to some owners who want a single-action method for saving (e.g., those who also own a few other modules that require manual saves). Another cost is that manually switching to the screensaver now produces the pause that saving entails, but it's not the worst thing given that manually switching to the screensaver isn't critically important during performance.