Skip to content

Commit

Permalink
try to run with git-bash on windows
Browse files Browse the repository at this point in the history
  • Loading branch information
jensens committed Feb 28, 2024
1 parent d5f5200 commit ad1a385
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
14 changes: 11 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ jobs:
os:
- ubuntu-latest
- macos-latest
- windows-latest
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
Expand All @@ -24,8 +25,15 @@ jobs:
with:
python-version: ${{ matrix.python-version }}
cache: "pip"
- name: Install Project
- name: Install Project (Windows)
if: runner.os == 'Windows'
run: make SHELL='C:/Program Files/Git/usr/bin/bash' install
- name: Install Project (Unix)
if: runner.os != 'Windows'
run: make install

- name: Run Tests
- name: Run Tests (Windows)
if: runner.os == 'Windows'
run: make SHELL='C:/Program Files/Git/usr/bin/bash' test
- name: Run Tests (Unix)
if: runner.os != 'Windows'
run: make test
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ FORMAT_TARGETS?=
export PATH:=$(if $(EXTRA_PATH),$(EXTRA_PATH):,)$(PATH)

# Defensive settings for make: https://tech.davis-hansson.com/p/make/
SHELL:=bash
SHELL?=bash
.ONESHELL:
# for Makefile debugging purposes add -x to the .SHELLFLAGS
.SHELLFLAGS:=-eu -o pipefail -O inherit_errexit -c
Expand Down

0 comments on commit ad1a385

Please sign in to comment.