refactor: 적절한 예외 적용 #8

myBuddyGuard · Sep 18, 2024 · 316a54a · 316a54a
1 parent caa3452
commit 316a54a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/be/src/main/java/buddyguard/mybuddyguard/weight/entity/Weight.java b/be/src/main/java/buddyguard/mybuddyguard/weight/entity/Weight.java
@@ -1,5 +1,6 @@
 package buddyguard.mybuddyguard.weight.entity;
 
+import buddyguard.mybuddyguard.exception.InvalidRequestException;
 import jakarta.persistence.Entity;
 import jakarta.persistence.GeneratedValue;
 import jakarta.persistence.GenerationType;
@@ -47,7 +48,7 @@ public void update(LocalDateTime recordedAt, Double weight, String description)
 
     public void validateOwnership(Long petId) {
         if (!this.petId.equals(petId)) {
-            throw new RuntimeException(); // 적절한 예외 적용하기
+            throw new InvalidRequestException();
         }
     }
 }
diff --git a/be/src/main/java/buddyguard/mybuddyguard/weight/service/WeightService.java b/be/src/main/java/buddyguard/mybuddyguard/weight/service/WeightService.java
@@ -1,5 +1,6 @@
 package buddyguard.mybuddyguard.weight.service;
 
+import buddyguard.mybuddyguard.exception.RecordNotFoundException;
 import buddyguard.mybuddyguard.weight.entity.Weight;
 import buddyguard.mybuddyguard.mapper.WeightMapper;
 import buddyguard.mybuddyguard.weight.contoller.request.WeightCreateRequest;
@@ -38,7 +39,7 @@ public List<WeightResponse> getAllWeightRecords(Long petId) {
     public WeightResponse getDetailWeightRecord(Long id, Long petId) {
 
         Weight weight = weightRepository.findById(id)
-                .orElseThrow(RuntimeException::new); // 적절한 예외 적용하기
+                .orElseThrow(RecordNotFoundException::new);
 
         weight.validateOwnership(petId);
 
@@ -63,7 +64,7 @@ public void updateWeightRecord(Long id, WeightUpdateRequest request) {
     public void deleteWeightRecord(Long id) {
 
         Weight weight = weightRepository.findById(id)
-                .orElseThrow(RuntimeException::new); // 적절한 예외 적용하기
+                .orElseThrow(RecordNotFoundException::new); // 적절한 예외 적용하기
 
         weightRepository.delete(weight);
     }