-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kumbiaphp #10
Add Kumbiaphp #10
Conversation
I'll check your files as soon as possible |
I made some changes, in the bash files.
In |
plz follow the template
You can't use it like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the last /index
to have a fair bench. I understand to add it again.
But in a benchmark the length of the response and URL is important. The response need to be exactly the same length. In this case the response is 33b, 12b from the "Hello World!" and the rest from the output data. And in reality we need to check also the length of the headers.
The top performers in this bench, don't use a public dir in the URL.
Siler, Fatfree, Slim, ... they don't have a default public dir.
So the index.php is created inside the framework dir, not inside a public dir.
URLs:
url="$base/$fw/index.php/hello/index"
url="$base/$fw/public/index.php/hello/index"
url="$base/$fw/default/public/index.php/hello/index"
...
a part of the length of the framework name, that also the top performers is shorter than the rest.
In some cases in this bench, the length difference of the URL is the same that the response.
We need to include the index.php
, inside a public dir for the microframeworks that don't have it (also the pure-php), to have a better fair play.
In a real situation, the server will point directly to the public dir from any full stack framework.
PD: it's easily demonstrable the impact of a large URL vs a shorter one in a benchmark.
Oh no! Considering the minimum overhead |
Added the PR #13 |
Woow 👍 The difference with the Kenjis bench (from 1.0-dev to 1.1.5), the most important changes for the performance are:
|
No description provided.