Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync llama.cpp #62

Merged
merged 3 commits into from
Dec 31, 2024
Merged

feat: sync llama.cpp #62

merged 3 commits into from
Dec 31, 2024

Conversation

jhen0409
Copy link
Member

@jhen0409 jhen0409 commented Dec 20, 2024

sync to 0ca416c

@jhen0409
Copy link
Member Author

jhen0409 commented Dec 20, 2024

ggerganov/llama.cpp#10906 seems to break builds on linux arm64 platform, I need to figure out later.

@jhen0409
Copy link
Member Author

@hans00
Copy link
Collaborator

hans00 commented Dec 21, 2024

Seems clang-cl also not work.
But MinGW chould not work with delayload toolchain (Node API linking).

Maybe need #15 or patch CMakeLists.txt to make it buildable.

P.S. MSVC looks not support FP16

@hans00
Copy link
Collaborator

hans00 commented Dec 21, 2024

patch CMakeLists.txt

Looks this change could build.

---             message(FATAL_ERROR "MSVC is not supported for ARM, use clang")
+++             list(APPEND ARCH_FLAGS /arch:armv8.7)

P.S. X Elite is ARMv8.7-A

@jhen0409
Copy link
Member Author

patch CMakeLists.txt

Looks this change could build.

---             message(FATAL_ERROR "MSVC is not supported for ARM, use clang")
+++             list(APPEND ARCH_FLAGS /arch:armv8.7)

P.S. X Elite is ARMv8.7-A

Confirmed it works, but latest commit of llama.cpp still broken on linux arm64 build. I probably don't have time to deal with that, so I just rollback to ggerganov/llama.cpp@0a11f8b.

@jhen0409 jhen0409 merged commit 5cfa9d6 into main Dec 31, 2024
1 check passed
@jhen0409 jhen0409 deleted the sync-llama-cpp branch December 31, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants