Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Solved link to absolute paths with spaces #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[BUGFIX] Solved link to absolute paths with spaces #26

wants to merge 1 commit into from

Conversation

JKetelaar
Copy link

Example output before change:

/usr/local/bin/php /Users/ketelaar/Projects/My Project/bin/console

This basically means you are executing /Users/ketelaar/Projects/My with php

Example output after change:

/usr/local/bin/php /Users/ketelaar/Projects/My\ Project/bin/console

@JKetelaar
[BUGFIX] Solved link to absolute paths with spaces
6f1d0ab 
*Example output before change:*
```
/usr/local/bin/php /Users/ketelaar/Projects/My Project/bin/console 
```
This basically means you are executing `/Users/ketelaar/Projects/My` with php

Example output after change:
```
/usr/local/bin/php /Users/ketelaar/Projects/My\ Project/bin/console 
```
@scrutinizer-notifier
Copy link

The inspection completed: 1 new issues

@JKetelaar
Copy link
Author

@gavinlove Bump

@gavinlove
Copy link
Member

Although this fixes the problem you have I don't think it is the right solution. I am going to look into escapeshellarg instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JKetelaar @scrutinizer-notifier @gavinlove