Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compatibility to Handsontable 7.0.2 #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update compatibility to Handsontable 7.0.2 #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a504c28
Update text renderer for compatibility with 7.0.2
itbm May 2, 2019
38986fb
Update demo to 7.0.2
itbm May 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions demo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ function customDropdownRenderer(instance, td, row, col, prop, value, cellPropert
var optionsList = cellProperties.chosenOptions.data;

if(typeof optionsList === "undefined" || typeof optionsList.length === "undefined" || !optionsList.length) {
Handsontable.cellTypes.text.renderer(instance, td, row, col, prop, value, cellProperties);
Handsontable.renderers.TextRenderer.apply(this, arguments);
return td;
}

Expand All @@ -75,6 +75,6 @@ function customDropdownRenderer(instance, td, row, col, prop, value, cellPropert
}
value = value.join(", ");

Handsontable.cellTypes.text.renderer(instance, td, row, col, prop, value, cellProperties);
Handsontable.renderers.TextRenderer.apply(this, arguments);
return td;
}
4 changes: 2 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@

<link rel="stylesheet prefetch" href="https://cdnjs.cloudflare.com/ajax/libs/chosen/1.4.2/chosen.css">
<link rel="stylesheet prefetch"
href="https://cdnjs.cloudflare.com/ajax/libs/handsontable/0.19.0/handsontable.full.css">
href="https://cdnjs.cloudflare.com/ajax/libs/handsontable/7.0.2/handsontable.full.css">
</head>
<body>

<div id="handsontable"></div>

<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/2.1.3/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/chosen/1.4.2/chosen.jquery.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/handsontable/0.19.0/handsontable.full.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/handsontable/7.0.2/handsontable.full.js"></script>
<script src="handsontable-chosen-editor.js"></script>
<script src="demo.js"></script>
</body>
Expand Down