minor ui fix + bump version to 0.0.9

myntra · Mar 16, 2017 · 56ea0bf · 56ea0bf
1 parent 436880c
commit 56ea0bf
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 22 deletions.
diff --git a/README.md b/README.md
@@ -2,7 +2,7 @@
 
 [![Platform](https://img.shields.io/badge/platform-android-green.svg)](http://developer.android.com/index.html)
 ![SDK](https://img.shields.io/badge/SDK-16%2B-green.svg)
-![Release](https://img.shields.io/badge/release-0.0.8-green.svg)
+![Release](https://img.shields.io/badge/release-0.0.9-green.svg)
 [![Jitpack](https://jitpack.io/v/myntra/CoachMarks.svg)](https://jitpack.io/#myntra/CoachMarks)
 [![Build Status](https://travis-ci.org/myntra/CoachMarks.svg?branch=master)](https://travis-ci.org/myntra/CoachMarks)
 [![CircleCI](https://circleci.com/gh/myntra/CoachMarks.svg?style=svg)](https://circleci.com/gh/myntra/CoachMarks)
@@ -23,7 +23,7 @@ Add jitpack to your root `build.gradle`
 Add the dependency
 ```
 	dependencies {
-	        compile 'com.github.myntra:CoachMarks:0.0.8'
+	        compile 'com.github.myntra:CoachMarks:0.0.9'
 	}
 ```
 

diff --git a/coachmarks/build.gradle b/coachmarks/build.gradle
@@ -9,7 +9,7 @@ android {
         minSdkVersion versions.minSdk
         targetSdkVersion versions.targetSdk
         versionCode 1
-        versionName "0.0.8"
+        versionName "0.0.9"
         vectorDrawables.useSupportLibrary = true
     }
 

diff --git a/coachmarks/src/main/res/layout/pop_up_coach_mark.xml b/coachmarks/src/main/res/layout/pop_up_coach_mark.xml
@@ -43,28 +43,15 @@
                 android:background="@drawable/coachmark_pop_up_drawable"
                 android:visibility="visible">
 
-                <android.support.v7.widget.AppCompatTextView
-                    android:id="@+id/tv_ok_button"
-                    android:layout_width="@dimen/coach_mark_pop_up_ok_button_width"
-                    android:layout_height="@dimen/coach_mark_pop_up_ok_button_width_height"
-                    android:backgroundTint="@color/coach_mark_transparent_color"
-                    android:ellipsize="end"
-                    android:gravity="center"
-                    android:maxLength="@integer/coach_mark_text_max_lines"
-                    android:text="@string/coachmark_ok_button_text"
-                    android:textAllCaps="true"
-                    android:textColor="@color/coach_mark_button_text_color"
-                    android:textSize="@dimen/coach_mark_text_size_ok_button" />
-
                 <LinearLayout
                     android:id="@+id/ll_coachmark_text_wrapper_layout"
-                    android:layout_width="148dp"
+                    android:layout_width="wrap_content"
                     android:layout_height="@dimen/coach_mark_pop_up_text_view_height"
                     android:orientation="horizontal">
 
                     <android.support.v7.widget.AppCompatTextView
                         android:id="@+id/tv_coachmark_text"
-                        android:layout_width="match_parent"
+                        android:layout_width="wrap_content"
                         android:layout_height="match_parent"
                         android:layout_marginBottom="@dimen/coach_mark_text_padding_top_bottom"
                         android:layout_marginLeft="@dimen/coach_mark_pop_up_text_padding_left"
@@ -88,6 +75,19 @@
                     android:layerType="software"
                     android:src="@drawable/coach_mark_vertical_dashed_line_separator" />
 
+                <android.support.v7.widget.AppCompatTextView
+                    android:id="@+id/tv_ok_button"
+                    android:layout_width="@dimen/coach_mark_pop_up_ok_button_width"
+                    android:layout_height="@dimen/coach_mark_pop_up_ok_button_width_height"
+                    android:backgroundTint="@color/coach_mark_transparent_color"
+                    android:ellipsize="end"
+                    android:gravity="center"
+                    android:maxLength="@integer/coach_mark_text_max_lines"
+                    android:text="@string/coachmark_ok_button_text"
+                    android:textAllCaps="true"
+                    android:textColor="@color/coach_mark_button_text_color"
+                    android:textSize="@dimen/coach_mark_text_size_ok_button" />
+
             </RelativeLayout>
 
             <View

diff --git a/sample/build.gradle b/sample/build.gradle
@@ -9,7 +9,7 @@ android {
         minSdkVersion versions.minSdk
         targetSdkVersion versions.targetSdk
         versionCode 1
-        versionName "0.0.8"
+        versionName "0.0.9"
     }
 
     buildTypes {

diff --git a/sample/src/main/java/com/myntra/sample/CoachMarksDemoActivity.java b/sample/src/main/java/com/myntra/sample/CoachMarksDemoActivity.java
@@ -10,6 +10,7 @@
 import com.myntra.coachmarks.builder.CoachMarkBuilder;
 import com.myntra.coachmarks.builder.ImageLayoutInformation;
 import com.myntra.coachmarks.builder.InfoForViewToMask;
+import com.myntra.coachmarks.common.CoachMarkTextGravity;
 import com.myntra.coachmarks.common.DialogDismissButtonPosition;
 import com.myntra.coachmarks.common.PopUpPosition;
 
@@ -49,8 +50,9 @@ private void showCoachMark() {
         ImageLayoutInformation imageLayoutInformation = ImageLayoutInformation.create(R.dimen.image_width, R.dimen.image_height).build();
         CoachMarkBuilder testBuilder = CoachMarkBuilder.create(anchorTop, anchorBottom, R.string.coach_mark_pdp_collections)
                 .setImageLayoutInformation(imageLayoutInformation)
-                .setUserDesiredPopUpPositionWithRespectToView(PopUpPosition.RIGHT)
-                .setPopUpCoachMarkDismissButtonPosition(DialogDismissButtonPosition.RIGHT)
+                .setUserDesiredPopUpPositionWithRespectToView(PopUpPosition.TOP)
+                .setPopUpCoachMarkDismissButtonPosition(DialogDismissButtonPosition.LEFT)
+                .setCoachMarkTextGravity(CoachMarkTextGravity.CENTER)
                 .setNotchPosition(.34).setInfoForViewToMaskList(infoForViewToMaskArrayList)
                 .setImageDrawableRes(R.drawable.similar_item_drawable)
                 .setFontStyleForCoachMarkText(FILE_NAME_MYNTRA_FONT_REGULAR)

diff --git a/sample/src/main/res/values/strings.xml b/sample/src/main/res/values/strings.xml
@@ -1,4 +1,4 @@
 <resources>
     <string name="app_name">CoachMarks</string>
-    <string name="coach_mark_pdp_collections">Long press to quickly save item to wishlist</string>
+    <string name="coach_mark_pdp_collections">Tap &amp; hold to save \n item to other collections</string>
 </resources>