Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow configuration based on shipping classes #1145

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

FlorianSDV
Copy link
Contributor

@FlorianSDV FlorianSDV commented Aug 14, 2024

INT-567

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 65.67797% with 81 lines in your changes missing coverage. Please review.

Project coverage is 59.88%. Comparing base (24d68e3) to head (e5419cc).
Report is 1 commits behind head on beta.

Files with missing lines Patch % Lines
...s/frontend/checkout-core/src/utils/useCartStore.ts 0.00% 15 Missing and 1 partial ⚠️
views/frontend/checkout-core/src/main.ts 0.00% 11 Missing and 1 partial ⚠️
...ews/frontend/checkout-delivery-options/src/main.ts 0.00% 10 Missing ⚠️
...heckout-core/src/blocks/getBlocksCheckoutConfig.ts 0.00% 9 Missing ⚠️
...rontend/checkout-core/src/utils/getShippingRate.ts 0.00% 8 Missing and 1 partial ⚠️
...ivery-options/src/utils/getHighestShippingClass.ts 0.00% 7 Missing and 1 partial ⚠️
views/frontend/checkout-core/src/types.ts 0.00% 7 Missing ⚠️
views/frontend/checkout-core/src/blocks/index.ts 0.00% 5 Missing and 1 partial ⚠️
views/frontend/checkout-core/src/utils/index.ts 0.00% 3 Missing ⚠️
...ntend/checkout-delivery-options/src/utils/index.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               beta    #1145      +/-   ##
============================================
- Coverage     61.66%   59.88%   -1.79%     
+ Complexity      671      619      -52     
============================================
  Files           108      106       -2     
  Lines          3524     3233     -291     
  Branches         25       23       -2     
============================================
- Hits           2173     1936     -237     
+ Misses         1326     1274      -52     
+ Partials         25       23       -2     
Flag Coverage Δ
backend 67.78% <100.00%> (-2.02%) ⬇️
checkout 0.00% <0.00%> (ø)
frontend 0.00% <0.00%> (ø)
unit 59.88% <65.67%> (-1.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Aug 16, 2024

PDK upgrade summary

The following packages were upgraded:

Package Old version New version
myparcelnl/pdk 2.43.2 2.43.3

@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Aug 16, 2024

✅ Build successful!

You can find a link to the downloadable artifact below.

Name Link
Commit e5419cc
Logs https://github.com/myparcelnl/woocommerce/actions/runs/11066826729
Download https://github.com/myparcelnl/woocommerce/suites/28920421293/artifacts/1986299222

@joerivanveen joerivanveen changed the title Feat/use shipping classes florian feat: migrate shipping classes package types settings Aug 20, 2024
@joerivanveen joerivanveen changed the title feat: migrate shipping classes package types settings feat: use shipping classes Aug 20, 2024
@joerivanveen joerivanveen marked this pull request as ready for review August 29, 2024 07:42
@joerivanveen joerivanveen requested a review from a team as a code owner August 29, 2024 07:42
@EdieLemoine EdieLemoine force-pushed the feat/use-shipping-classes-florian branch 2 times, most recently from 343dd9a to 01740bf Compare September 4, 2024 14:28
@EdieLemoine EdieLemoine force-pushed the feat/use-shipping-classes-florian branch from 01740bf to 9da979f Compare September 4, 2024 14:31
@EdieLemoine EdieLemoine changed the title feat: use shipping classes feat: allow configuration based on shipping classes Sep 4, 2024
@FlorianSDV FlorianSDV force-pushed the feat/use-shipping-classes-florian branch from ccd6c17 to 6a6f570 Compare September 13, 2024 07:49
src/Migration/Pdk/SettingsMigration.php Outdated Show resolved Hide resolved
src/Migration/Pdk/SettingsMigration.php Outdated Show resolved Hide resolved
src/Pdk/Context/Service/WcContextService.php Show resolved Hide resolved
src/Pdk/Plugin/WcShippingMethodRepository.php Outdated Show resolved Hide resolved
src/Pdk/Plugin/WcShippingMethodRepository.php Show resolved Hide resolved
src/Pdk/Plugin/WcShippingMethodRepository.php Outdated Show resolved Hide resolved
tests/mock_wp_functions.php Show resolved Hide resolved
@FreekVR
Copy link

FreekVR commented Sep 16, 2024

Vind het lastig op te bepalen in hoeverre dit breaking changes zijn. Op zich kun je tussen twee beta versies zoveel breaking changes hebben als je wil, maar volgens mij zijn er best wel wat klanten al doorverwezen om de beta te installeren?

Ik denk goed om de impact van deze changes/release te bepalen en waar nodig dan ook duidelijk te documenteren & communiceren.

@myparcel-bot myparcel-bot bot force-pushed the feat/use-shipping-classes-florian branch from fca4da8 to a386799 Compare September 20, 2024 14:47
@myparcel-bot myparcel-bot bot force-pushed the feat/use-shipping-classes-florian branch from a386799 to 1a87fc0 Compare September 20, 2024 14:56
@EdieLemoine EdieLemoine force-pushed the feat/use-shipping-classes-florian branch from 1a87fc0 to 1a1cdc8 Compare September 20, 2024 14:56
@myparcel-bot myparcel-bot bot force-pushed the feat/use-shipping-classes-florian branch 2 times, most recently from 2ed71db to 14e8007 Compare September 20, 2024 15:18
EdieLemoine and others added 2 commits September 20, 2024 18:09
fix: fix the shipping things

refactor: remove log statements

test: rework to single test maintaining same values

test: improve coverage

style: add comment and change layout

wip: increase test coverage

refactor: implement more codacy suggestions

refactor: implement codacy suggestions

chore: update phpstan baseline

style: clean upp code

test: add mock wc shipping zones and methods

test: remove unnecessary class

test: remove unnecessary factory

test: remove snapshot

test: finalize wc context service test

test: implement mock wp cache

wip: update mock cart and retrieve wp_term

feat: remove cart from product settings migration

wip: continue with mock classes

wip: start with mock classes

wip

wip: migrate old shipping classes

wip: use shipping classes in shipping method logic
@myparcel-bot myparcel-bot bot force-pushed the feat/use-shipping-classes-florian branch from 14e8007 to 12dae8a Compare September 20, 2024 18:09
@myparcel-bot myparcel-bot bot added the approved (Auto) label Sep 23, 2024
@EdieLemoine EdieLemoine merged commit ff282a1 into beta Sep 27, 2024
8 of 10 checks passed
@EdieLemoine EdieLemoine deleted the feat/use-shipping-classes-florian branch September 27, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved (Auto)
Development

Successfully merging this pull request may close these issues.

4 participants