Bug fixes

myrotvorets · Sep 30, 2023 · 6505e57 · 6505e57
1 parent 6447161
commit 6505e57
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/test/functional/controllers/monitoring.test.mts b/test/functional/controllers/monitoring.test.mts
@@ -1,5 +1,7 @@
 import express, { type Express } from 'express';
+import { expect } from 'chai';
 import request from 'supertest';
+import type { HealthChecker } from '@cloudnative/health-connect';
 import { healthChecker, monitoringController } from '../../../src/controllers/monitoring.mjs';
 
 describe('MonitoringController', function () {
@@ -12,7 +14,8 @@ describe('MonitoringController', function () {
     });
 
     beforeEach(function () {
-        healthChecker.shutdownRequested = false;
+        expect(healthChecker).not.to.be.undefined;
+        (healthChecker as HealthChecker).shutdownRequested = false;
     });
 
     afterEach(function () {
@@ -23,7 +26,7 @@ describe('MonitoringController', function () {
         request(app).get(`/monitoring/${endpoint}`).expect('Content-Type', /json/u).expect(200);
 
     const checker503 = (endpoint: string): Promise<unknown> => {
-        healthChecker.shutdownRequested = true;
+        (healthChecker as HealthChecker).shutdownRequested = true;
         return request(app).get(`/monitoring/${endpoint}`).expect('Content-Type', /json/u).expect(503);
     };
 

diff --git a/test/unit/services/fixtures.mts b/test/unit/services/fixtures.mts
@@ -1,3 +1,4 @@
+import { Readable } from 'node:stream';
 import type { RawResponse } from '@myrotvorets/facex';
 
 export const fakeFile: Express.Multer.File = {
@@ -6,7 +7,7 @@ export const fakeFile: Express.Multer.File = {
     encoding: 'binary',
     mimetype: 'video/mp4',
     size: 1048576,
-    stream: null,
+    stream: new Readable(),
     destination: '/tmp',
     filename: 'test.mp4',
     path: '',
@@ -113,7 +114,7 @@ export const failedVideoResult: RawResponse = {
         client_id: 'facex/node',
         reqID_serv: '00000000-0000-0000-0000-000000000000',
         reqID_clnt: clientGUID,
-        segment: null,
+        segment: '',
         datetime: Date.now().toString(),
         result_code: -1,
         results_amount: 0,
@@ -130,7 +131,7 @@ export const emptyVideoResult: RawResponse = {
         client_id: 'facex/node',
         reqID_serv: '00000000-0000-0000-0000-000000000000',
         reqID_clnt: clientGUID,
-        segment: null,
+        segment: '',
         datetime: Date.now().toString(),
         result_code: 3,
         results_amount: 0,
@@ -147,7 +148,7 @@ export const successfulVideoResult = (data: string): RawResponse => ({
         client_id: 'facex/node',
         reqID_serv: '00000000-0000-0000-0000-000000000000',
         reqID_clnt: clientGUID,
-        segment: null,
+        segment: '',
         datetime: Date.now().toString(),
         result_code: 3,
         results_amount: 0,

diff --git a/tsconfig.json b/tsconfig.json
@@ -10,7 +10,6 @@
         "declaration": false,
         "removeComments": false,
         "strict": true,
-        "strictNullChecks": false,
         "noUnusedLocals": true,
         "noUnusedParameters": false,
         "noFallthroughCasesInSwitch": true,