[scorecards] fix the show specific council section page dropdown #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarino
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
This isn’t actually doing what the search box is meant to do (it’s meant to select one of the council type buttons below, based on the council_type of the council you select in the autocomplete) – but I guess adding the council as a comparison is fine, instead, since it automatically selects the right council type and also adds a column with the council’s mark on each question, which people might find useful.
|
Oh right, that is not at all what I would have expected it to do. |
struan
force-pushed
the
594-fix-council-page-specific-council-dropdown
branch
from
4a39902 to
f17beba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #594