Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brent] Bulky waste missed can be reported if no event by following day #5073

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

MorayMySoc
Copy link
Contributor

If the bulky waste collection hasn't been marked as missed from Echo can be reported as missed/collected after 6pm by the booker.

https://mysocietysupport.freshdesk.com/a/tickets/3500

[skip changelog]

@MorayMySoc MorayMySoc requested a review from dracos July 19, 2024 14:24
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.49%. Comparing base (de4e3ab) to head (8ead724).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5073   +/-   ##
=======================================
  Coverage   82.49%   82.49%           
=======================================
  Files         406      406           
  Lines       31697    31708   +11     
  Branches     5041     5042    +1     
=======================================
+ Hits        26148    26158   +10     
- Misses       4059     4063    +4     
+ Partials     1490     1487    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, only mentioned in Slack not here, but looks like might have been forgotten. The ticke says if he day has passed, not 6pm (so midnight the start of the next day).

@MorayMySoc MorayMySoc requested review from dracos and removed request for dracos August 2, 2024 16:50
@MorayMySoc MorayMySoc requested a review from dracos August 2, 2024 16:52
@MorayMySoc MorayMySoc changed the title [Brent] Bulky waste missed can be reported if no event by 6pm [Brent] Bulky waste missed can be reported if no event by following day Aug 2, 2024
If the small items collection hasn't been marked as missed from
Echo, it can be reported as missed/collected the next day.

https://mysocietysupport.freshdesk.com/a/tickets/3500
@dracos dracos merged commit 8ead724 into master Sep 17, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants