Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Northumberland] Fetch 'detailed_information' (extra details) to/from Alloy & assigned user to Alloy #5147

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

nephila-nacrea
Copy link
Contributor

@nephila-nacrea nephila-nacrea commented Aug 29, 2024

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@40461e5). Learn more about missing BASE report.
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
perllib/FixMyStreet/App/Controller/Report.pm 85.71% 0 Missing and 1 partial ⚠️
perllib/Open311/UpdatesBase.pm 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5147   +/-   ##
=========================================
  Coverage          ?   82.51%           
=========================================
  Files             ?      406           
  Lines             ?    31732           
  Branches          ?     5049           
=========================================
  Hits              ?    26185           
  Misses            ?     4056           
  Partials          ?     1491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nephila-nacrea nephila-nacrea self-assigned this Sep 3, 2024
@nephila-nacrea nephila-nacrea force-pushed the nland-assigned-to-extra-details branch 3 times, most recently from 224a88b to 828c26e Compare September 9, 2024 17:02
@nephila-nacrea nephila-nacrea changed the title [Northumberland] Pull 'detailed_information' (extra details) from Alloy [Northumberland] Pull 'detailed_information' (extra details) to/from Alloy & assigned user to Alloy Sep 9, 2024
@nephila-nacrea nephila-nacrea changed the title [Northumberland] Pull 'detailed_information' (extra details) to/from Alloy & assigned user to Alloy [Northumberland] Fetch 'detailed_information' (extra details) to/from Alloy & assigned user to Alloy Sep 9, 2024
@nephila-nacrea nephila-nacrea force-pushed the nland-assigned-to-extra-details branch 2 times, most recently from bb6d52d to 10ac3cd Compare September 10, 2024 05:16
@nephila-nacrea nephila-nacrea marked this pull request as ready for review September 10, 2024 05:18
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All clear and makes sense :) A few suggestions, shout if don't make sense

&& ( $problem->get_extra_metadata('detailed_information') // '' )
ne $old_detailed_information
) {
$update_params{extra}{detailed_information} = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess issue here is if someone edits the extra detail, and the assignment, that has two updates rather than combining them in the one. Do we think that matters? I'm not sure. I like the way you've hooked it round planned_reports to catch any usage there, I wonder if there's some way that can be hooked in here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ^.^ I didn't think it mattered - and trying to consolidate them into one update seemed like it would be a headache, given that the assigned user logic kind of exists in its own bubble.

Copy link
Contributor Author

@nephila-nacrea nephila-nacrea Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am still wondering, though, what I should do about the updates displaying on the /report/<id> page :-/

Copy link
Member

@dracos dracos Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see in report/updates.html there's a "IF update.get_extra_metadata triage_report" type thing to skip those updates. Perhaps we take this opportunity to add a staff_only flag to updates (for there as well) and have it use that to skip these updates. Seems easier than trying to decide based on contents (given the updates in the template can include questionnaire replies as well etc).
Not sure that's easy for the update on detailed information, though, hmm.

perllib/FixMyStreet/App/Controller/Report.pm Show resolved Hide resolved
t/cobrand/northumberland.t Show resolved Hide resolved
@dracos dracos force-pushed the nland-assigned-to-extra-details branch 2 times, most recently from c02aed2 to de608ee Compare September 18, 2024 16:15
@dracos dracos force-pushed the nland-assigned-to-extra-details branch from de608ee to 702d107 Compare September 19, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants