Fix admin editing of anonymous reports #5174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracos
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Ah great, thanks, I had this on my list to do as it came up as a side effect in FD-4569.
I don't think we would ever want to make the anonymous user not anonymous, and username shouldn't matter if not present, but I agree, might as well pass them all back for now just to match what it was before.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5174 +/- ##
==========================================
- Coverage 82.49% 82.48% -0.01%
==========================================
Files 406 406
Lines 31716 31716
Branches 5044 5044
==========================================
- Hits 26164 26162 -2
- Misses 4063 4065 +2
Partials 1489 1489 ☔ View full report in Codecov by Sentry. |
davea
force-pushed
the
admin-anon-report-editing
branch
from
c3f13db
to
09f71ee
Compare
Not submitting the name field would cause a DB error because it would try to set `name` to NULL. And including the other two seemed like a good idea too.
davea
force-pushed
the
admin-anon-report-editing
branch
from
09f71ee
to
65b55d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not submitting the name field would cause a DB error because it would try to set
nameto NULL.And including the other two seemed like a good idea too.
[skip changelog]