Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Open311] Add --exclude to bin/open311-populate-service-list #5177

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

davea
Copy link
Member

@davea davea commented Sep 19, 2024

Allows bodies to be excluded from Open311 service list fetching.

This seemed like the simplest approach and matches what we do for bin/fetch. Other options I considered were adding a "skip service list fetch" checkbox to the body admin edit page, and adding a cobrand hook to allow cobrand to opt-out of service list fetching.

Allows bodies to be excluded from Open311 service list fetching.
@davea davea requested a review from dracos September 19, 2024 11:22
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.49%. Comparing base (65b55d9) to head (caae438).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5177   +/-   ##
=======================================
  Coverage   82.48%   82.49%           
=======================================
  Files         406      406           
  Lines       31716    31716           
  Branches     5044     5044           
=======================================
+ Hits        26162    26164    +2     
+ Misses       4065     4063    -2     
  Partials     1489     1489           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is fine, though I guess to match fetch, we'd have bodies_exclude in the Populate package and do the exclusion in there, which would then make this testable as well. But is small thing.

@davea davea merged commit caae438 into master Sep 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants