Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Greenwich] Update link colour. #5180

Merged
merged 1 commit into from
Sep 19, 2024
Merged

[Greenwich] Update link colour. #5180

merged 1 commit into from
Sep 19, 2024

Conversation

dracos
Copy link
Member

@dracos dracos commented Sep 19, 2024

Update to match their site. The front page colour didn't seem to do anything, and the visited seemed pointless. [skip changelog] Fixes https://github.com/mysociety/societyworks/issues/3435

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.49%. Comparing base (caae438) to head (73acd35).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5180      +/-   ##
==========================================
- Coverage   82.49%   82.49%   -0.01%     
==========================================
  Files         406      406              
  Lines       31716    31716              
  Branches     5044     5044              
==========================================
- Hits        26164    26163       -1     
- Misses       4063     4064       +1     
  Partials     1489     1489              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lucascumsille lucascumsille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other approach would be to remove the visited bit altogether.

web/cobrands/greenwich/base.scss Outdated Show resolved Hide resolved
@lucascumsille
Copy link
Contributor

@dracos I think this should be ready =)

@dracos dracos merged commit 73acd35 into master Sep 19, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants