-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GOVUK styling to 'View area reports' sections #5185
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5185 +/- ##
=======================================
Coverage 82.40% 82.40%
=======================================
Files 409 409
Lines 32042 32042
Branches 5109 5109
=======================================
+ Hits 26404 26405 +1
+ Misses 4125 4124 -1
Partials 1513 1513 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a bit confused because the parent item-list--wards
is extending a child %item-list__item--link
mixin, which I see works (apart from having to override the padding), but I wonder if it would be clearer if that mixin was changed to a parent one used by item-list--wards
and item-list--reports
. I've added a commit that also makes the hover take up the full width, as before, let me know if that looks okay.
Good point, I made some amendments for this bit and the other two comments. Let me know if this makes more sense. |
28dd807
to
96f6c65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was still a child/parent issue - I've pushed a change to hopefully explain better than me trying to explain it, let me know if that makes sense (and should be done if so)
96f6c65
to
efa6470
Compare
It does thank you =) @dracos I have rebase everything into one commit. |
Fixes: https://github.com/mysociety/societyworks/issues/3822
Changes the current markup for the ward-list inputs so it resembles the GOVUK one.
Screen.Recording.2024-09-24.at.15.02.34.mov
[Skip changelog]