Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GOVUK styling to 'View area reports' sections #5185

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

lucascumsille
Copy link
Contributor

@lucascumsille lucascumsille commented Sep 24, 2024

Fixes: https://github.com/mysociety/societyworks/issues/3822

Changes the current markup for the ward-list inputs so it resembles the GOVUK one.

Screen.Recording.2024-09-24.at.15.02.34.mov

[Skip changelog]

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.40%. Comparing base (bc0538e) to head (efa6470).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5185   +/-   ##
=======================================
  Coverage   82.40%   82.40%           
=======================================
  Files         409      409           
  Lines       32042    32042           
  Branches     5109     5109           
=======================================
+ Hits        26404    26405    +1     
+ Misses       4125     4124    -1     
  Partials     1513     1513           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit confused because the parent item-list--wards is extending a child %item-list__item--link mixin, which I see works (apart from having to override the padding), but I wonder if it would be clearer if that mixin was changed to a parent one used by item-list--wards and item-list--reports. I've added a commit that also makes the hover take up the full width, as before, let me know if that looks okay.

web/cobrands/sass/_base.scss Outdated Show resolved Hide resolved
@lucascumsille
Copy link
Contributor Author

lucascumsille commented Nov 4, 2024

I was a bit confused because the parent item-list--wards is extending a child %item-list__item--link mixin, which I see works (apart from having to override the padding), but I wonder if it would be clearer if that mixin was changed to a parent one used by item-list--wards and item-list--reports. I've added a commit that also makes the hover take up the full width, as before, let me know if that looks okay.

Good point, I made some amendments for this bit and the other two comments. Let me know if this makes more sense.

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was still a child/parent issue - I've pushed a change to hopefully explain better than me trying to explain it, let me know if that makes sense (and should be done if so)

web/cobrands/sass/_base.scss Outdated Show resolved Hide resolved
web/cobrands/sass/_base.scss Outdated Show resolved Hide resolved
web/cobrands/sass/_base.scss Outdated Show resolved Hide resolved
@lucascumsille
Copy link
Contributor Author

There was still a child/parent issue - I've pushed a change to hopefully explain better than me trying to explain it, let me know if that makes sense (and should be done if so)

It does thank you =) @dracos I have rebase everything into one commit.

@lucascumsille lucascumsille merged commit efa6470 into master Nov 4, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants