Shortlist button focusable

[lucascumsille]

Bug found while working on this PR: #5208

This PR changes the markup of label.btn--shortlist and swaps it for button.btn--shortlist, that way the element is focusable and can also be interacted via keyboard.

[Skip changelog]

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 82.41%. Comparing base (bd545ee) to head (a6ebf9a).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
web/cobrands/fixmystreet/fixmystreet.js	0.00%	13 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5228   +/-   ##
=======================================
  Coverage   82.40%   82.41%           
=======================================
  Files         409      409           
  Lines       32041    32042    +1     
  Branches     5109     5109           
=======================================
+ Hits        26403    26406    +3     
+ Misses       4125     4123    -2     
  Partials     1513     1513           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dracos]

This works, but I wonder if there's an easier solution - if we switch this label to be an actual button with form="planned_form" (and adjustments accordingly) then I don't think the submit button in the planned_form is even needed - perhaps whoever did this originally didn't know buttons in a form can actually be linked to a different form?

[lucascumsille]

This works, but I wonder if there's an easier solution - if we switch this label to be an actual button with form="planned_form" (and adjustments accordingly) then I don't think the submit button in the planned_form is even needed - perhaps whoever did this originally didn't know buttons in a form can actually be linked to a different form?

Thanks for the feedback, I thought there would be a more powerful reason to use input and label. So I swapped it for a button and it seems to be working =)

Screen.Recording.2024-10-23.at.15.11.49.mov

[dracos]

Looks good apart from one removal

[dracos]

Great :)