-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bexley] Spot open container requests #5236
[Bexley] Spot open container requests #5236
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bexley-ww-container-requests #5236 +/- ##
=============================================================
Coverage 82.42% 82.43%
=============================================================
Files 410 410
Lines 32147 32165 +18
Branches 5130 5133 +3
=============================================================
+ Hits 26498 26515 +17
- Misses 4140 4141 +1
Partials 1509 1509 ☔ View full report in Codecov by Sentry. |
4441789
to
a538bfc
Compare
4f52505
to
99bbc13
Compare
a538bfc
to
248d23d
Compare
99bbc13
to
41457d7
Compare
248d23d
to
42dd286
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is on the right track.
As I understand it, we ought to be doing separate checks for open delivery vs open removal reports.
That does make it more complicated though; I don't know if this will do as a first attempt to show Bexley. (Also, I didn't realise it would be touching the form code and I am still getting my removals PR in place). We could always refine later.
FYI there's a bug that means if any wheelie bin has an open request, all wheelie bins are disabled (I think it's the bug I fix in 8e58de9, but you may want to double-check that).
"As I understand it, we ought to be doing separate checks for open delivery vs open removal reports." - sorry, I didn't follow this bit. The tech spec says if there's an open collect/deliver then both request and removal should be disabled, I think? |
d63c56b
to
d87b842
Compare
d87b842
to
903aff9
Compare
Checking I've got the right idea. Fixes https://github.com/mysociety/societyworks/issues/4571