Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bexley] Spot open container requests #5236

Merged

Conversation

dracos
Copy link
Member

@dracos dracos commented Oct 29, 2024

Checking I've got the right idea. Fixes https://github.com/mysociety/societyworks/issues/4571

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.43%. Comparing base (0047b49) to head (903aff9).
Report is 7 commits behind head on bexley-ww-container-requests.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           bexley-ww-container-requests    #5236   +/-   ##
=============================================================
  Coverage                         82.42%   82.43%           
=============================================================
  Files                               410      410           
  Lines                             32147    32165   +18     
  Branches                           5130     5133    +3     
=============================================================
+ Hits                              26498    26515   +17     
- Misses                             4140     4141    +1     
  Partials                           1509     1509           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dracos dracos force-pushed the bexley-ww-container-requests-spot-open branch from 4441789 to a538bfc Compare October 30, 2024 10:07
@dracos dracos marked this pull request as ready for review October 30, 2024 10:07
@dracos dracos force-pushed the bexley-ww-container-requests branch from 4f52505 to 99bbc13 Compare October 30, 2024 16:26
@dracos dracos force-pushed the bexley-ww-container-requests-spot-open branch from a538bfc to 248d23d Compare October 30, 2024 16:27
@dracos dracos force-pushed the bexley-ww-container-requests branch from 99bbc13 to 41457d7 Compare October 30, 2024 16:46
@dracos dracos force-pushed the bexley-ww-container-requests-spot-open branch from 248d23d to 42dd286 Compare October 30, 2024 16:47
Copy link
Contributor

@nephila-nacrea nephila-nacrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is on the right track.
As I understand it, we ought to be doing separate checks for open delivery vs open removal reports.
That does make it more complicated though; I don't know if this will do as a first attempt to show Bexley. (Also, I didn't realise it would be touching the form code and I am still getting my removals PR in place). We could always refine later.

FYI there's a bug that means if any wheelie bin has an open request, all wheelie bins are disabled (I think it's the bug I fix in 8e58de9, but you may want to double-check that).

perllib/FixMyStreet/Cobrand/Bexley/Waste.pm Show resolved Hide resolved
templates/web/bexley/waste/services.html Show resolved Hide resolved
templates/web/bexley/waste/services.html Outdated Show resolved Hide resolved
@dracos
Copy link
Member Author

dracos commented Oct 31, 2024

"As I understand it, we ought to be doing separate checks for open delivery vs open removal reports." - sorry, I didn't follow this bit. The tech spec says if there's an open collect/deliver then both request and removal should be disabled, I think?

@dracos dracos force-pushed the bexley-ww-container-requests-spot-open branch from d63c56b to d87b842 Compare October 31, 2024 07:44
@dracos dracos force-pushed the bexley-ww-container-requests-spot-open branch from d87b842 to 903aff9 Compare October 31, 2024 11:55
@dracos dracos merged commit 903aff9 into bexley-ww-container-requests Oct 31, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants