Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bexley] Spot updates on container requests. #5241

Conversation

dracos
Copy link
Member

@dracos dracos commented Nov 1, 2024

[skip changelog] Fixes https://github.com/mysociety/societyworks/issues/4572

This would involve adding the below to the server configuration (I guessed the mapped states, I don't think we've been given them?). (Note that I would be in favour of adding admin templates with these texts in, and then not having them in the server configuration at all, that would have the same outcome with less configuration needed.)

The alert update email already includes a "Contact us" link to https://mybexley.bexley.gov.uk/service/rubbish_and_recycling_enquiries so I'm going to take that as already covered by that.

container_delivery_state_mapping:
  Container Delivered:
    fms_state: fixed - council
    text: Our waste contractor has confirmed that your new bin has been delivered.
Duplicate Request
    fms_state: duplicate
    text: Our waste contractor has advised that your request to deliver a new bin could not be completed as this is a duplicate of an earlier request.
Existing bin is usable
    fms_state: unable to fix?
    text: Our waste contractor has advised that your request to deliver a new bin could not be completed as the existing bin at your property is usable and does not need to be replaced.
Incorrect container for property
    fms_state: unable to fix?
    text: Our waste contractor has advised that your request to deliver a new bin could not be completed as this bin is not suitable for your property.
Multiple bins not allowed
    fms_state: unable to fix?
    text: Our waste contractor has advised that your request to deliver a new bin could not be completed because you already have a bin of this type at your property.
No access
    fms_state: unable to fix?
    text: Our waste contractor has advised that your request to deliver a new bin could not be completed because the waste contractor could not gain access.
Not required
    fms_state: cancelled?
    text: Our waste contractor has advised that your request to deliver a new bin could not be completed because the team were informed that this request was no longer required.
container_removal_state_mapping:
  Container Removed
    fms_state: fixed - council
    text: Our waste contractor has confirmed that your old bin has been collected.
  Duplicate Request
    fms_state: duplicate
    text: Our waste contractor has advised that your request to collect your old bin could not be completed as this is a duplicate of an earlier request.
  Existing bin is usable
    fms_state: unable to fix?
    text: Our waste contractor has advised that your request to collect your old bin could not be completed as the existing bin at your property is usable and does not need to be replaced.
  Incorrect container for property
    fms_state: unable to fix?
    text: Our waste contractor has advised that your request to collect your old bin could not be completed as this bin is not suitable for your property.
  Multiple bins not allowed
    fms_state: unable to fix?
    text: Our waste contractor has advised that your request to collect your old bin could not be completed because you already have a bin of this type at your property.
  No access
    fms_state: unable to fix?
    text: Our waste contractor has advised that your request to collect your old bin could not be completed because the waste contractor could not gain access to the bin.
  Not available for removal
    fms_state: unable to fix?
    text: Our waste contractor has advised that your request to collect your old bin could not be completed because the bin was not available for removal.
  Not required
    fms_state: cancelled?
    text: Our waste contractor has advised that your request to collect your old bin could not be completed because the team were informed that this request was no longer required.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.52%. Comparing base (c2724a2) to head (ea89c95).
Report is 1 commits behind head on bexley-ww-container-requests.

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/Bexley/Waste.pm 68.75% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##           bexley-ww-container-requests    #5241      +/-   ##
================================================================
- Coverage                         82.53%   82.52%   -0.02%     
================================================================
  Files                               410      410              
  Lines                             32726    32735       +9     
  Branches                           5159     5160       +1     
================================================================
+ Hits                              27012    27016       +4     
- Misses                             4198     4202       +4     
- Partials                           1516     1517       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dracos dracos force-pushed the bexley-ww-container-requests-failure-to-deliver branch from 144caee to ea89c95 Compare November 4, 2024 15:18
@dracos dracos merged commit ea89c95 into bexley-ww-container-requests Nov 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants