Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UK] Deal with Senedd code rename. #386

Merged
merged 1 commit into from
May 17, 2022
Merged

[UK] Deal with Senedd code rename. #386

merged 1 commit into from
May 17, 2022

Conversation

dracos
Copy link
Member

@dracos dracos commented May 11, 2022 •
edited
Loading

Fixes #385

@dracos dracos mentioned this pull request May 11, 2022
Closed
@codecov
Copy link

codecov bot commented May 11, 2022 •
edited
Loading

Codecov Report

Merging #386 (f668519) into master (b71a2bd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #386   +/-   ##
=======================================
  Coverage   71.96%   71.96%           
=======================================
  Files          39       39           
  Lines        2297     2297           
=======================================
  Hits         1653     1653           
  Misses        644      644

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b71a2bd...f668519. Read the comment docs.

@dracos dracos requested a review from davea May 17, 2022 07:58
davea
davea approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@davea davea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I noticed this when doing the Labour BL import, ended up adding WPC code in a fixture but this is cleaner.

@dracos dracos merged commit f668519 into master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davea davea davea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error due to WPC areas in May 2022 boundary line data
2 participants
@dracos @davea