WIP: use babel v7 #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
commented
Oct 2, 2017
| @@ -12,7 +12,9 @@ | |||
| "peerDependencies": { | |||
| "eslint": ">=3.1.0" | |||
| }, | |||
| "dependencies": {}, | |||
| "dependencies": { | |||
There was a problem hiding this comment.
woops this should be devDeps.
mysticatea
reviewed
Oct 3, 2017
| errors: ["Unexpected a rest property."], | ||
| }, | ||
| { | ||
| code: "let {a, ...{}} = obj", |
There was a problem hiding this comment.
This is a syntax error in the final spec. ObjectPattern and ArrayPattern cannot be after rest operator.
There was a problem hiding this comment.
Probably worth just ditching the tests then?
There was a problem hiding this comment.
ESLint's test runner cannot include test cases which include syntax errors. Those are failed always even if it's in invalid tests. So I merely removed those commented-out codes in the master branch.
There was a problem hiding this comment.
@mysticatea cool, I closed the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.