Add support for git config commit.cleanup & git config commit.verbose
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitabobko
force-pushed
the
bobko/commit-cleanup-and-verbose
branch
3 times, most recently
from
c8aea70 to
4fc1ce0
Compare
Rename because the function not only strips the comments but removes trailing empty lines as well. Althought I dropped `if comments:` line, this commit doesn't change any semantic or programm behaviour, because comments were never passed as `None`. Also now the code looks more valid (after I dropped `if comments:` line) because we should drop trailing empty lines even when no comments are passed. Co-authored-by: ruro <[email protected]>
This commit doesn't change any semantic or behaviour. Co-authored-by: ruro <[email protected]>
…tent This commit doesn't change any semantic or behaviour. Co-authored-by: ruro <[email protected]>
I'm going to change this function behaviour in the next commits. So let's firstly cover the current behaviour with tests. Co-authored-by: ruro <[email protected]>
Added: - Remove trailing whitespace in each line - Remove leading empty lines - Collapse consecutive empty lines Co-authored-by: ruro <[email protected]>
See `--cleanup` in `man git commit`. Fix mystor#108 Co-authored-by: ruro <[email protected]>
See `--verbose` in `man git commit`. Fix mystor#29 Co-authored-by: ruro <[email protected]>
nikitabobko
force-pushed
the
bobko/commit-cleanup-and-verbose
branch
from
4fc1ce0 to
979242e
Compare
|
Force push to resolve conflicts |
|
This PR might look big and hard to review. But just review it commit-by-commit. I spent time making it easy to review |
|
I've been using this branch for a few months without any issues, I am very happy with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #108 and #29
I'm not fluent in Python so let me know about any stupid mistakes.
Each commit is atomic so the easiest way to review this PR is commit-by-commit.
Co-authored-by: @RuRo