Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please consider the following formatting changes to #13498 #1

Closed
wants to merge 1 commit into from
Closed

Please consider the following formatting changes to #13498 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Framework/Core/include/Framework/ASoAHelpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,13 +82,13 @@ std::vector<BinningIndex> groupTable(const T& table, const BP<Cs...>& binningPol
return groupedIndices;
}

for(auto rowIterator : table) {
auto values = binningPolicy.getBinningValues(rowIterator);
auto val = binningPolicy.getBin(values);
for (auto rowIterator : table) {
auto values = binningPolicy.getBinningValues(rowIterator);
auto val = binningPolicy.getBin(values);

if (val != outsider) {
groupedIndices.emplace_back(val, *std::get<1>(rowIterator.getIndices()));
}
if (val != outsider) {
groupedIndices.emplace_back(val, *std::get<1>(rowIterator.getIndices()));
}
}

// Do a stable sort so that same categories entries are
Expand Down
3 changes: 0 additions & 3 deletions Framework/Core/test/benchmark_ASoA.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,8 +321,6 @@ static void BM_ASoADynamicColumnPresentGetValueByLabel(benchmark::State& state)

BENCHMARK(BM_ASoADynamicColumnPresentGetValueByLabel)->Range(8, 8 << maxrange);



static void BM_ASoADynamicColumnCall(benchmark::State& state)
{
// Seed with a real random value, if available
Expand Down Expand Up @@ -380,5 +378,4 @@ static void BM_ASoADynamicColumnCallGetValueByLabel(benchmark::State& state)
}
BENCHMARK(BM_ASoADynamicColumnCallGetValueByLabel)->Range(8, 8 << maxrange);


BENCHMARK_MAIN();