Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend sourcing from unpkg rather than from cdn.my.wisc #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# myuw-banner versions

## Next (3.1.0?)

+ Updates documentation and example to recommend sourcing from unpkg.com, not from cdn.my.wisc.edu.

## 3.0.0 - 2021-04-23

BREAKING CHANGES:
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ Include the component as follows:

```html
<!-- import the module -->
<script type="module" src="https://cdn.my.wisc.edu/@myuw-web-components/myuw-banner@latest/myuw-banner.min.mjs"></script>
<script type="module" src="https://unpkg.com/@myuw-web-components/myuw-banner@latest/dist/myuw-banner.min.mjs"></script>

<!-- fallback for browsers without ES2015 module support -->
<script nomodule src="https://cdn.my.wisc.edu/@myuw-web-components/myuw-banner@latest/myuw-banner.min.js"></script>
<script nomodule src="https://unpkg.com/@myuw-web-components/myuw-banner@latest/dist/myuw-banner.min.js"></script>

<myuw-banner
message="MyUW"
Expand Down
4 changes: 2 additions & 2 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@

<!-- MyUW web components -->
<script type="module">
import "https://cdn.my.wisc.edu/@myuw-web-components/myuw-app-styles@latest/myuw-app-styles.min.mjs";
import "https://cdn.my.wisc.edu/@myuw-web-components/myuw-app-bar@latest/myuw-app-bar.min.mjs";
import "https://unpkg.com/@myuw-web-components/myuw-app-styles@latest/dist/myuw-app-styles.min.mjs";
import "https://unpkg.com/@myuw-web-components/myuw-app-bar@latest/dist/myuw-app-bar.min.mjs";
import "./dist/myuw-banner.mjs";
</script>

Expand Down