Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent integer overflow during midpoint calculation in binaryInsertionSort #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pineapplemachine
Copy link

@pineapplemachine pineapplemachine commented Nov 25, 2016

Changed line 211 from

let mid = (left + right) >>> 1;

to

let mid = left + ((right - left) >>> 1);

because the previous implementation would yield incorrect results for large values of left and/or right.

This is the way the operation is done, for example, in gallopLeft on line 315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant