Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous transpiling fix #13

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

apowers313
Copy link

Related to issue #12

Changes:

  • The previous fix would sendTask twice with asynchronous code. This adds sendTask to an else statement in _runNow so that runs in either the transpiling OR if the transpiler isn't run.
  • Uses a Promise if it exists; otherwise does the try / catch inside a polyfill. Should make the code easier to upgrade if / when bumping up to a new version of node.js; and makes it easier to read in the meantime.

@n-riesco
Copy link
Owner

n-riesco commented Dec 5, 2020

This return should ensure sendTask is run only once. If you're really convinced this is happening, I'll try to reproduce the issue, but I need to be able to reproduce it, so that I can write a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants