The HTTP/3 protocol on iroh #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no Cargo.lock file though so this is painful. Next release should solve this.
|
Should we add the |
oh, i hadn't considered that. I think it might be too early. I don't think those traits are 1.0 yet and putting them in an unstable feature flag is a bit meh and sets too much precedence for throwing things into iroh-net. Should be fine as a separate crate for now. But if we want to take this more serious we should indeed give it its own repo and some docs etc. |
|
@flub do we want to merge this? |
totally! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a low-level API from hyper which can be used directly. It also includes primitive support for running an axum server.
The latter does some extra copies and puts too much in memory. It should still be generalised into more generic hyper support with parametrised body etc.
This currently relies on a git reference to iroh-net. The 0.28 iroh-net release should fix this, probably best to wait until that release to merge this so that this does not break CI for the other examples randomly as there's no Cargo.lock checked in.