refactor(iroh-net): Switch to new iroh-relay route /relay instead of /derp
#2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
5 tasks
flub
approved these changes
Jul 2, 2024
|
Or rather - merge after the 0.20 release was published. Read this comment for the reasoning. |
|
According to @Arqu the relays are now updated to 0.20. If nothing else comes up, I'll merge tomorrow (if I end up with enough time at a computer in Brussels). |
|
Sounds good, let's merge! |
4 tasks
|
I don't really understand why the base branch didn't switch automatically here :/ |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
…f `/derp` (#2489) Split out from #2419, copy of #2441, because I forgot to switch the base branch 🙃 Splitting this out means we can deploy the relay changes one release in advance to the changes in the client. Otherwise, we'd need to update the relays ASAP when we release 0.20, as clients will expect to be able to connect to the `/relay` route (which may not be deployed immediately after the release). ## Description - Switches the client to connect to `/relay` instead of `/derp`. ## Breaking Changes None ## Notes & open questions Also a PR related to #2378 I allowed myself to add in another `derive_more::Debug` instance instead of a custom, outdated `impl Debug`, if that's okay with you 😁 ## Change checklist - [X] Self-review. - [X] Documentation updates if relevant. - [X] Tests if relevant. - [X] All breaking changes documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #2419
Splitting this out means we can deploy the relay changes one release in advance to the changes in the client.
Otherwise, we'd need to update the relays ASAP when we release 0.20, as clients will expect to be able to connect to the
/relayroute (which may not be deployed immediately after the release).Description
/relayinstead of/derp.Breaking Changes
None
Notes & open questions
Also a PR related to #2378
I allowed myself to add in another
derive_more::Debuginstance instead of a custom, outdatedimpl Debug, if that's okay with you 😁Change checklist