Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: global token of a module should be accessible by itself (singleton) #1582

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kamilkisiela
Copy link
Collaborator

@kamilkisiela kamilkisiela commented Nov 17, 2022

Urigo/graphql-modules#2278

The issue: missing design:paramtypes

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2022

⚠️ No Changeset found

Latest commit: dc2284e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

🚀 Website Preview

The latest changes to the website are available as preview in: https://70fc6279.envelop.pages.dev

@theguild-bot
Copy link
Collaborator

theguild-bot commented Nov 17, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 495282      ✗ 0     
     data_received......................................: 1.9 GB  13 MB/s
     data_sent..........................................: 108 MB  718 kB/s
     envelop_total......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:prom-tracing }............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     event_loop_lag.....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:prom-tracing }............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_blocked...................................: avg=2.81µs  min=800ns    med=1.6µs   max=12.23ms  p(90)=2.5µs   p(95)=3µs    
     http_req_connecting................................: avg=265ns   min=0s       med=0s      max=5.02ms   p(90)=0s      p(95)=0s     
     http_req_duration..................................: avg=5.62ms  min=210.51µs med=4ms     max=103.55ms p(90)=11.82ms p(95)=18.26ms
       { expected_response:true }.......................: avg=5.62ms  min=210.51µs med=4ms     max=103.55ms p(90)=11.82ms p(95)=18.26ms
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=4.72ms  min=453.03µs med=4.13ms  max=47.61ms  p(90)=8.01ms  p(95)=9.74ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=3.03ms  min=210.51µs med=2.32ms  max=26.9ms   p(90)=5.95ms  p(95)=9ms    
     ✓ { mode:envelop-just-cache }......................: avg=4.77ms  min=409.82µs med=4.07ms  max=52.66ms  p(90)=8.22ms  p(95)=9.96ms 
     ✓ { mode:graphql-js }..............................: avg=8.96ms  min=861.78µs med=7.55ms  max=94.02ms  p(90)=14.22ms p(95)=16.53ms
     ✓ { mode:prom-tracing }............................: avg=21.77ms min=2.44ms   med=18.99ms max=103.55ms p(90)=36.22ms p(95)=38.43ms
     http_req_failed....................................: 0.00%   ✓ 0           ✗ 247641
     http_req_receiving.................................: avg=57.96µs min=13.8µs   med=26µs    max=22.45ms  p(90)=43.5µs  p(95)=52.9µs 
     http_req_sending...................................: avg=46.04µs min=5.4µs    med=9.79µs  max=17.92ms  p(90)=18.3µs  p(95)=28.1µs 
     http_req_tls_handshaking...........................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...................................: avg=5.52ms  min=170.41µs med=3.92ms  max=103.51ms p(90)=11.52ms p(95)=18.14ms
     http_reqs..........................................: 247641  1650.811138/s
     iteration_duration.................................: avg=6.04ms  min=452.23µs med=4.37ms  max=104.51ms p(90)=12.4ms  p(95)=18.73ms
     iterations.........................................: 247641  1650.811138/s
     vus................................................: 9       min=1         max=17  
     vus_max............................................: 20      min=20        max=20  

saihaj
saihaj previously approved these changes Nov 17, 2022
@n1ru4l
Copy link
Owner

n1ru4l commented Nov 17, 2022

@saihaj bruh you approved a failing test? :D

@saihaj
Copy link
Collaborator

saihaj commented Nov 17, 2022

@saihaj bruh you approved a failing test? :D

oops I just saw benchmark which fails time to time didn't realize the actual test also failed

@saihaj saihaj dismissed their stale review November 17, 2022 11:10

tests need fixing

@n1ru4l
Copy link
Owner

n1ru4l commented Nov 22, 2022

@kamilkisiela what are the next steps here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants