feat(response-cache): added getScope callback in buildResponseCacheKey #2202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue related : #2181
Description
Include a
getScope
callback inbuildResponseCacheKey
to enable an Apollo like behavior, wherePUBLIC
scopes have only one cache key to get better performances on larger scales.Type of change
How Has This Been Tested?
I added some unit tests to check that
PRIVATE
scope is correctly retrieved from a query, when directive@cacheControl(scope: PRIVATE)
is put on query, field and subfield.Checklist:
CONTRIBUTING doc and the
style guidelines of this project