Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [plugins/prometheus] fixes for phases/shouldObserve for Yoga #2326

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EmrysMyrddin
Copy link
Collaborator

Minor fixes required to propagate phases/shouldObserve new config to Yoga plugin.

Copy link

changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: b05f813

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@envelop/prometheus 12.0.0-alpha-20241112124749-b05f813adacaed7f3a2132da52552b4511ccbc15 npm ↗︎ unpkg ↗︎

@theguild-bot
Copy link
Collaborator

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 771474      ✗ 0     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: 100.00% ✓ 164884      ✗ 0     
     ✓ { mode:envelop-cache-jit }.......................: 100.00% ✓ 339940      ✗ 0     
     ✓ { mode:envelop-just-cache }......................: 100.00% ✓ 165464      ✗ 0     
     ✓ { mode:graphql-js }..............................: 100.00% ✓ 101186      ✗ 0     
     data_received......................................: 2.9 GB  25 MB/s
     data_sent..........................................: 168 MB  1.4 MB/s
     envelop_init.......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     envelop_total......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     event_loop_lag.....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_context....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_execute....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_parse......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_validate...................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_blocked...................................: avg=2.93µs  min=1.22µs   med=2.59µs  max=9.93ms   p(90)=3.52µs  p(95)=3.92µs 
     http_req_connecting................................: avg=20ns    min=0s       med=0s      max=810.62µs p(90)=0s      p(95)=0s     
     http_req_duration..................................: avg=2.82ms  min=152.76µs med=2.73ms  max=38.33ms  p(90)=5.2ms   p(95)=6.05ms 
       { expected_response:true }.......................: avg=2.82ms  min=152.76µs med=2.73ms  max=38.33ms  p(90)=5.2ms   p(95)=6.05ms 
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=3.36ms  min=445.86µs med=3ms     max=23.8ms   p(90)=5.69ms  p(95)=6.17ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=1.46ms  min=152.76µs med=1.21ms  max=15.92ms  p(90)=2.44ms  p(95)=2.6ms  
     ✓ { mode:envelop-just-cache }......................: avg=3.35ms  min=370.44µs med=2.98ms  max=24.07ms  p(90)=5.62ms  p(95)=6.14ms 
     ✓ { mode:graphql-js }..............................: avg=5.64ms  min=855.94µs med=4.85ms  max=38.33ms  p(90)=9.43ms  p(95)=10.25ms
     http_req_failed....................................: 0.00%   ✓ 0           ✗ 385737
     http_req_receiving.................................: avg=36.04µs min=12.95µs  med=31.27µs max=9.5ms    p(90)=48µs    p(95)=51.54µs
     http_req_sending...................................: avg=12.71µs min=4.07µs   med=9.88µs  max=11.23ms  p(90)=19.69µs p(95)=21.11µs
     http_req_tls_handshaking...........................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...................................: avg=2.77ms  min=125.48µs med=2.68ms  max=38.13ms  p(90)=5.15ms  p(95)=5.99ms 
     http_reqs..........................................: 385737  3214.376978/s
     iteration_duration.................................: avg=3.1ms   min=360.11µs med=2.98ms  max=40.51ms  p(90)=5.49ms  p(95)=6.33ms 
     iterations.........................................: 385737  3214.376978/s
     vus................................................: 10      min=10        max=10  
     vus_max............................................: 20      min=20        max=20  

Copy link
Contributor

💻 Website Preview

The latest changes are available as preview in: https://2a7f3525.envelop.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants