Jdk21 upgrade and Springboot 3 #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please add "hacktoberfest" and if accepted "hacktoberfest-accepted" |
n2o
requested changes
Oct 4, 2023
There was a problem hiding this comment.
Please change the JDKs in the GitHub CI to 21 in the matrix build: https://github.com/n2o/url-shortener/blob/master/.github/workflows/gradle.yml#L10
Also please update the Dockerfile
|
Kudos, SonarCloud Quality Gate passed!
|
|
hi @n2o, I cannot find some images for gradle 8.3 that supports jdk21. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary disable some unit test in controller layer
Upgrade thymeleaf
Migrate javax to jakarta