Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android touch support #527

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

wasper1
Copy link

@wasper1 wasper1 commented Oct 23, 2016

Issue #527
The aim of this PR is to extend chart to support Android touch devices.
I've tested this on:
Android 4.4.2
Android 4.0.3

@wasper1
Copy link
Author

wasper1 commented Oct 23, 2016

Please trigger CI again or change some configuration cause e2e tests failed on webdriver Error: ECONNREFUSED connect ECONNREFUSED

@wasper1 wasper1 mentioned this pull request Oct 23, 2016
@lorem--ipsum
Copy link
Member

Hi, thanks for the PR. Unfortunately I've been working on a big update (switching to TS2 and a different modules manager, mainly) and your PR will probably have to be updated. I'll help you through this if you want, though.

@chaosmail
Copy link
Contributor

Thanks for the great contribution! I think this feature could be great for v2 as well. I fixed a couple of things, especially these bugs with travis in the latest PR, and merged the changes in your branch. I would not mind porting it to the new latest dev version, but maybe @wasper1 can help us out on this!

@chaosmail
Copy link
Contributor

Nice travis is passing now! However, we should definitly have some e2e test on this feature.

@chaosmail
Copy link
Contributor

Resolves #535

@chaosmail
Copy link
Contributor

I moved the branch to feat/android-touch for now, so I can rebase on master and add some tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants