-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Granular REST API requests to Godaddy, updating individual records only #42
base: master
Are you sure you want to change the base?
Conversation
…rds that get processed in batch on a record-type basis. Also fixes a bug with removing a Godaddy API non-supported record type.
@kolikons: Is this something you would mind adding to your fork to make it more easily accessible? |
@jakob-northvolt Yes, I'm aware of that. But since kolikons code are accessible as a provider from the registry I just thought it would make sense to merge in the changes you made on your fork. |
kolikons#2 |
I'm sorry, I did not see first that you pinged kolikons in your comment, I thought it was aimed for me. I understand what you meant now. |
Hey @jakob-northvolt - thanks for the PR. Could you merge in the latest code from the main branch? |
Yes, np, I'll do it asap |
Gents, we started using this provider and stumbled with this issue as well. Is there an estimate for this PR to be merged? Thanks for sharing. |
hello @jakob-northvolt could you resolve the merge conflicts? |
Unfortunately, I don't think this PR fixes #39. The plan will still show everything changing - Terraform doesn't seem very good at figuring out when two items in a set are the same :( |
Without a fix for the issue mentioned - this plugin is severely limited. |
This is a sorely needed fix. |
Any chance on getting this merged in? |
I guess @jakob-northvolt would have to resolve the conflicts first. |
Any updates on this? |
Facing similar issues, I've decided to re-implement provider from scratch to operate on record level. |
Code is commented so should be reasonably self-explainatory.
@ records will be submitted in batch because there is no way to separate out them on a subdomain basis
Any other records with both unique type and name will be submitted individually