Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granular REST API requests to Godaddy, updating individual records only #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jakob-northvolt
Copy link

Code is commented so should be reasonably self-explainatory.

@ records will be submitted in batch because there is no way to separate out them on a subdomain basis

Any other records with both unique type and name will be submitted individually

ibuildit and others added 2 commits March 15, 2021 17:10
…rds that get processed in batch on a record-type basis. Also fixes a bug with removing a Godaddy API non-supported record type.
@ilons
Copy link

ilons commented Apr 19, 2021

@kolikons: Is this something you would mind adding to your fork to make it more easily accessible?

@ilons
Copy link

ilons commented Apr 20, 2021

Not sure I understand what you mean, my changes are in my fork.
For example:
https://github.com/jakob-northvolt/terraform-godaddy/blob/master/api/domains.go

@jakob-northvolt Yes, I'm aware of that. But since kolikons code are accessible as a provider from the registry I just thought it would make sense to merge in the changes you made on your fork.

@kolikons
Copy link

@kolikons: Is this something you would mind adding to your fork to make it more easily accessible?

kolikons#2
if u want to fix makefile =)

@jakob-northvolt
Copy link
Author

Not sure I understand what you mean, my changes are in my fork.
For example:
https://github.com/jakob-northvolt/terraform-godaddy/blob/master/api/domains.go

@jakob-northvolt Yes, I'm aware of that. But since kolikons code are accessible as a provider from the registry I just thought it would make sense to merge in the changes you made on your fork.

I'm sorry, I did not see first that you pinged kolikons in your comment, I thought it was aimed for me. I understand what you meant now.

@n3integration
Copy link
Owner

Hey @jakob-northvolt - thanks for the PR. Could you merge in the latest code from the main branch?

@jakob-northvolt
Copy link
Author

Yes, np, I'll do it asap

@emanuelceballos
Copy link

Gents, we started using this provider and stumbled with this issue as well. Is there an estimate for this PR to be merged? Thanks for sharing.

@alvarolloret
Copy link

hello @jakob-northvolt could you resolve the merge conflicts?

@domdomegg
Copy link
Contributor

Unfortunately, I don't think this PR fixes #39. The plan will still show everything changing - Terraform doesn't seem very good at figuring out when two items in a set are the same :(

@sheepsy90
Copy link

Without a fix for the issue mentioned - this plugin is severely limited.

@sps-software
Copy link

This is a sorely needed fix.

@maxolasersquad
Copy link

Any chance on getting this merged in?

@maxolasersquad
Copy link

I guess @jakob-northvolt would have to resolve the conflicts first.

@mesbahtanvir
Copy link

Any updates on this?
its really impossible to use it, almost gave up and updating manually now.

@veksh
Copy link

veksh commented Jan 3, 2024

Any updates on this? its really impossible to use it, almost gave up and updating manually now.

Facing similar issues, I've decided to re-implement provider from scratch to operate on record level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.