Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option for rundir (and misc other changes) #50

Merged
merged 7 commits into from
Aug 2, 2024

Conversation

hamishcoleman
Copy link
Contributor

  • Configure option for /run dir - needed for openwrt build
  • Several minor documentation improvements
  • Add more details to peer events

This benign informational message has caused confusion with users
several times.  Reword it to try and avoid this.
The structure of the packet stays the same, but the descriptive strings
change to allow clearer information.  This is technically an API change,
but is intended to be a minor one - there are no known users of these
strings.

TODO: document the event messages better, so that the exact state
transitions are more well known.
All modern Linux systems have the ephemeral local state directory
created at "/run" - however this is not universal even across just the
supported Linux systems.

Add a configure option to set the location of run dir that is compiled
into the binary.

(See PR n42n#48 and n42n#49)
It turns out that the openwrt systems that I have been using to test my
OpenWRT package builds (All Turris Omnia systems) appears to have had a
vendor patch applied to create a symlink from "/run" to "/var/run".  On
a vanilla OpenWRT system, there is no "/run".  Use the new configure
option to set the correct run dir location.

(Also deal with the OpenWRT auto conf tools being too old to include the
runstatedir option)

(See PR n42n#48, n42n#49)
@hamishcoleman hamishcoleman self-assigned this Aug 2, 2024
@hamishcoleman hamishcoleman merged commit 6b56d42 into n42n:main Aug 2, 2024
30 checks passed
@hamishcoleman hamishcoleman mentioned this pull request Aug 2, 2024
@small-5
Copy link
Contributor

small-5 commented Aug 2, 2024

The test is ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants